[vlc-devel] [PATCH] Optional pause when window inactive.

[Jean-Baptiste Kempf]

On Wed, Sep 14, 2011 at 11:32:52AM +0530, sanjeev mk wrote :
> Note - Audio playback is NOT paused.

WHy?

> The patch:

Wrong indentation.

> + var_InheritBool( p_intf, "qt-pause-inactive" ) )

No, cache the value.

> diff --git a/modules/gui/qt4/components/simple_preferences.cpp b/modules/gui/qt4/components/simple_preferences.cpp
> index dfe1376..f268929 100644
> --- a/modules/gui/qt4/components/simple_preferences.cpp
> +++ b/modules/gui/qt4/components/simple_preferences.cpp
> @@ -580,6 +580,7 @@ SPrefsPanel::SPrefsPanel( intf_thread_t *_p_intf, QWidget *_parent,
>              CONNECT( ui.systrayBox, toggled( bool ), ui.sysPop, setEnabled( bool ) );
>              ui.sysPop->setEnabled( ui.systrayBox->isChecked() );
>  
> +            CONFIG_BOOL( "qt-pause-inactive", pauseInactiveBox );
>              CONFIG_BOOL( "qt-pause-minimized", pauseMinimizedBox );
>              CONFIG_BOOL( "playlist-tree", treePlaylist );
>              CONFIG_BOOL( "play-and-pause", playPauseBox );

No, this isn't important enough to be in SPrefs.

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device