[vlc-devel] [PATCH] Optional pause when window inactive.

[sanjeev mk]

Sorry for the late reply.

On Thu, Sep 15, 2011 at 7:09 PM, Jean-Baptiste Kempf <jb at videolan.org>wrote:

> On Wed, Sep 14, 2011 at 11:32:52AM +0530, sanjeev mk wrote :
> > Note - Audio playback is NOT paused.
>
> WHy?
>
I meant, songs are not paused. Pure audio files aren't paused when changing
windows.

> > The patch:
>
> Wrong indentation.
>
> > + var_InheritBool( p_intf, "qt-pause-inactive" ) )
>
> No, cache the value.
>
> > diff --git a/modules/gui/qt4/components/simple_preferences.cpp
> b/modules/gui/qt4/components/simple_preferences.cpp
> > index dfe1376..f268929 100644
> > --- a/modules/gui/qt4/components/simple_preferences.cpp
> > +++ b/modules/gui/qt4/components/simple_preferences.cpp
> > @@ -580,6 +580,7 @@ SPrefsPanel::SPrefsPanel( intf_thread_t *_p_intf,
> QWidget *_parent,
> >              CONNECT( ui.systrayBox, toggled( bool ), ui.sysPop,
> setEnabled( bool ) );
> >              ui.sysPop->setEnabled( ui.systrayBox->isChecked() );
> >
> > +            CONFIG_BOOL( "qt-pause-inactive", pauseInactiveBox );
> >              CONFIG_BOOL( "qt-pause-minimized", pauseMinimizedBox );
> >              CONFIG_BOOL( "playlist-tree", treePlaylist );
> >              CONFIG_BOOL( "play-and-pause", playPauseBox );
>
> No, this isn't important enough to be in SPrefs.
>
> Would it be fine if I put it in Advanced Prefs > Video under General Video
Settings?

> Best Regards,
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/ - +33 672 704 734
> Sent from my Electronic Device
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>



-- 
Regards,
Sanjeev M K
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110918/959b9f3c/attachment.html>