[vlc-devel] [PATCH] Mac: qtsound - qtkit sound audio capture functionality

Jean-Baptiste Kempf jb at videolan.org
Thu Sep 22 08:45:58 CEST 2011

On Thu, Sep 22, 2011 at 05:42:53AM +0200, Feurstein, Michael wrote :
> This patch is a first attempt in integrating audio capturing functionality for mac on VLC.

Thanks for the work.

> Please review and feedback!

First you should squash your 3 patches. ('git rebase -i origin/master'
will help you)
Then, you should split you commits in 2:
 - qtsound.m and relevant configure.ac/Modules.am modifications
 - UI+.xib
You should remove tabs also in your code.
Finally, please be sure to remove the unnecessary includes in your code.

Best Regards,

Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device

More information about the vlc-devel mailing list