lukasz.m.luki at gmail.com
Wed Sep 21 21:53:09 CEST 2011
I'm sending patch with fixes to my previous patch.
> LGPL version 2? Shouldn't it be version 2.1?
> Avoid sizeof(char) because it is utterly pointless:
> Favor getline() over fgets(), unless the input lines can be assumed to be
> bound to a certain length.
> Use fully qualified function prototypes everywhere. Used '(void)' rather than
> '()' where applicable. This is C, not C++...
> Bug fixes or separate enhancements need separate patch file.
> Plug-in descriptor should only contain compilation-time constants, no function
> calls or conditionals other than from <vlc_plugin.h> macros expansion.
> json_stream_*() seem to be dead code. Using fdopen() would possibly simplify
> the code a lot.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 90367 bytes
Desc: not available
More information about the vlc-devel