[vlc-devel] JSON-RPC

Rémi Denis-Courmont remi at remlab.net
Tue Sep 20 19:05:39 CEST 2011

LGPL version 2? Shouldn't it be version 2.1?

Avoid sizeof(char) because it is utterly pointless:

Favor getline() over fgets(), unless the input lines can be assumed to be 
bound to a certain length.

Use fully qualified function prototypes everywhere. Used '(void)' rather than 
'()' where applicable. This is C, not C++...

Bug fixes or separate enhancements need separate patch file.

Plug-in descriptor should only contain compilation-time constants, no function 
calls or conditionals other than from <vlc_plugin.h> macros expansion.

json_stream_*() seem to be dead code. Using fdopen() would possibly simplify 
the code a lot.

Rémi Denis-Courmont

More information about the vlc-devel mailing list