[vlc-devel] [PATCH] Added option to disable chapter generation from marks file.

[Janne Kujanpää]

On 27.9.2011 6:26, Tobias Güntner wrote:
>
> Here's my (final?) patch. Two remarks:

>
> 2. I decided against a vdr-generate-chapters setting, because:
>
> * 'none' is pointless because I can't think of a compelling reason why
> someone would want to turn it off. Rémi asked a similar question when I
> posted the first access_vdr patch here; so far, nobody complained. ;)
>
I must admit this is partly true.

> * 'all' would be backwards compatible. To be honest, when I wrote the
> code to import cut marks two years ago, I could not think of any good
> "filter". For the sake of simplicity, I just added them all. I don't
> feel obliged to keep that behavior.
>
That was good point to start importing.

> * 'auto' makes sense if you consider cut marks simply as "seek targets".
> But as you already said: Why do we need them for parts which are
> supposed to be removed? Maybe if someone *really* misses them, we can
> add this mode in a future patch.
>
> * 'odd' is, in a way, what VDR does, so it makes sense to do that here,
> too. The only "issue" is that the end of a chapter is lost. Minor
> inconvenience, but no problem, I think.
>
Now big question. What if noad misses one point and all marks are 
inversed after that? That's my final reason for configurable cutmark.

-- 
Janne Kujanpää