[vlc-devel] [PATCH] Added option to disable chapter generation from marks file.

Tobias Güntner fatbull at web.de
Thu Sep 29 11:32:01 CEST 2011

Am 28.09.2011 23:51, schrieb Janne Kujanpää:
> What if noad misses one point and all marks are inversed after that?

Then noad has a *serious* bug and should be fixed. Is that really our

Just to be sure, I ran

find /video/ -name marks.vdr ! -exec awk '!/last/ && (NR % 2 ? !/start/
: !/lost/) { exit 1 }' {} \; -print

Lo and behold! 34 of my 1606 recordings have anomalies (e.g., two "Logo
lost" marks in a row without a "Logo start" between them). Some are two
years old, some two weeks. It's only 2%, but still ... *facepalm*

> That's my final reason for configurable cutmark.

You would have to notice that, for a particular recording, some chapters
are wrong, remember that there is an obscure VLC setting to fix that,
and restore it to the previous setting when you're done. I'm certainly
not going to do that and I don't expect an average user will. ;)

We could implement some kind of autodetection to work around this, e.g.,
look for two "logo lost" marks in a row, but my gut feeling tells me
this is a bottomless pit.

Removing "duplicate" cut marks is simple yet effective. Let's just do
that. Patch attached. What do you think?

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Skip-redundant-chapters.patch
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110929/a27cea9e/attachment.ksh>

More information about the vlc-devel mailing list