[vlc-devel] [PATCH 3/3] Add file dialogue to manually set album art.

[Jean-Baptiste Kempf]

On Wed, Aug 08, 2012 at 10:23:29AM +0200, Angelo Haller wrote :
> On 08/05/2012 11:32 PM, Jean-Baptiste Kempf wrote:
> >On Tue, Jul 31, 2012 at 02:34:04PM +0200, Angelo Haller wrote :
> >>+    CONNECT( THEMIM->getIM(), artChanged( QString ), this, enterEditMode() );
> >This seems dubious, like very dubious.
> 
> Any reason? I thought it would be useful to be able to save the artwork
> when it is changed. Either by setting an artwork manually or when an
> artwork is downloaded from the net.
> Or what seemed dubious to you?

If you open the dialog and then the core changes the art, like when a
new art was discovered, you directly get the button to pop up.

> >>+    QString filePath = QFileDialog::getOpenFileName( this, qtr( "Choose Image" ),
> >>+        p_intf->p_sys->filepath, qtr( "Image Files (*.gif *.jpg *.jpeg *.png)" ) );
> >Are you sure about the qtr use here?
> >
> Maybe I am mistaken but it looks fine to me.

Ok.

> >>+        if( old_url.startsWith( QString::fromUtf8( psz_cachedir ) ) )
> >>+            QFile( old_url ).remove(); /* Purge cached artwork */
> >Not leaking anythin here ?
> 
> Leaking in the sense of? Memory? I don't think so.

The return of QString::fromUtf8 I meant.

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device