[vlc-devel] [PATCH 3/3] Add file dialogue to manually set album art.

[Angelo Haller]

On 08/10/2012 05:12 PM, Jean-Baptiste Kempf wrote:
> On Wed, Aug 08, 2012 at 10:23:29AM +0200, Angelo Haller wrote :
>> On 08/05/2012 11:32 PM, Jean-Baptiste Kempf wrote:
>>> On Tue, Jul 31, 2012 at 02:34:04PM +0200, Angelo Haller wrote :
>>>> +    CONNECT( THEMIM->getIM(), artChanged( QString ), this, enterEditMode() );
>>> This seems dubious, like very dubious.
>> Any reason? I thought it would be useful to be able to save the artwork
>> when it is changed. Either by setting an artwork manually or when an
>> artwork is downloaded from the net.
>> Or what seemed dubious to you?
> If you open the dialog and then the core changes the art, like when a
> new art was discovered, you directly get the button to pop up.

Well... yeah it might be confusing although I think this would be
good behaviour. The button would pop up as soon as the arwork
is changed so that you can save it directly (without filling in some
nonsense to get the save button to appear).
But that is only my personal opinion. Not sure what users would expect.

>>>> +        if( old_url.startsWith( QString::fromUtf8( psz_cachedir ) ) )
>>>> +            QFile( old_url ).remove(); /* Purge cached artwork */
>>> Not leaking anythin here ?
>> Leaking in the sense of? Memory? I don't think so.
> The return of QString::fromUtf8 I meant.

This is actually an interesting question. What encoding is used for
URLs and file paths in vlc?
I assumed utf-8 for file paths since include/vlc_fs.h states:
"Those functions convert file paths from UTF-8 to the system-specific
encoding (especially UTF-16 on Windows)"

Best regards