[vlc-devel] [PATCH 1/2] Add new API to libvlc for persistent equalizer settings.

[Alexey Sokolov]

12.08.2012 19:59, Mark Lee ?????:
> Hello...
>
> On 12 August 2012 13:33, Alexey Sokolov <alexey at asokolov.org
> <mailto:alexey at asokolov.org>> wrote:
>
>     12.08.2012 19:29, Rémi Denis-Courmont ?????:
>     > Le dimanche 12 août 2012 13:49:37 Alexey Sokolov, vous avez écrit :
>     >> Hello.
>     >>
>     >> 12.08.2012 15:30, Mark Lee ?????:
>     >>> +/**
>     >>> + * Create a new default equalizer, with all frequency values
>     zeroed.
>     >>> + *
>     >>> + * The new equalizer can subsequently be associated with a
>     media player
>     >>> by using + * libvlc_media_player_set_equalizer().
>     >>> + *
>     >>> + * When the application is finished with a particular
>     equalizer instance
>     >>> it should + * disassociate it from the media player by invoking
>     >>> libvlc_media_player_set_equalizer(NULL) + * and then free it
>     by using
>     >>> libvlc_audio_equalizer_release().
>     >>> + *
>     >> Why not to use reference count, as other libvlc objects do?
>     > Why use a reference count? This is just plain (small) data.
>     >
>     > Way overkill.
>     >
>     To not to need to maintain validness of the pointer ourself.
>     If it's so small data, why not to store it inside the media_player
>     completely instead?
>     media_player would just memcpy the data to its field.
>
>
> I think one idea was that potentially an equalizer instance could be
> shared amongst multiple media players, so making a copy would not work
> if that were the case. That idea maybe strengthens the argument for a
> refcount.
>  
Well, if to make them shared amongst multiple media players... Forcing
user to count references on his own is bad.

-- 
Best regards,
Alexey "DarthGandalf" Sokolov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120812/a387b55b/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120812/a387b55b/attachment.sig>