[vlc-devel] [PATCH] Add new API to libvlc for persistent equalizer settings.

[Rémi Denis-Courmont]

Le mardi 21 août 2012 00:14:31 Mark Lee, vous avez écrit :
> > I may be missing something, but I don't see why that pointer is needed
> > inside
> > the media player anyway.
> 
> It was only so it could be easily retrieved by
> libvlc_media_player_get_equalizer(), but I guess it's questionable how
> useful that is.

Even with the lock, your code remains undefined if different threads set and 
get the equalizer parameters at the same time.

> It would simplify a bit if that method wasn't needed.
> 
> I suppose *if* it were needed a var_Address could be used instead? Or we
> could just say the equalizer pointer is not stored on the media player at
> all and it's up to the application to manage the situation. Do you have any
> opinion on that?

I don't see the difference. The life cycle of the pointer remains identical 
and identically dubious.

> Thanks again for your review comments. I'll have another go.

-- 
Rémi Denis-Courmont
C/C++ software engineer looking for a job
http://www.linkedin.com/in/remidenis