[vlc-devel] [PATCH] Add new API to libvlc for persistent equalizer settings.

[Mark Lee]

Hello again,

On 20 August 2012 22:26, Rémi Denis-Courmont <remi at remlab.net> wrote:

> Le mardi 21 août 2012 00:14:31 Mark Lee, vous avez écrit :
> > > I may be missing something, but I don't see why that pointer is needed
> > > inside
> > > the media player anyway.
> >
> > It was only so it could be easily retrieved by
> > libvlc_media_player_get_equalizer(), but I guess it's questionable how
> > useful that is.
>
> Even with the lock, your code remains undefined if different threads set
> and
> get the equalizer parameters at the same time.
>
> > It would simplify a bit if that method wasn't needed.
> >
> > I suppose *if* it were needed a var_Address could be used instead? Or we
> > could just say the equalizer pointer is not stored on the media player at
> > all and it's up to the application to manage the situation. Do you have
> any
> > opinion on that?
>
> I don't see the difference. The life cycle of the pointer remains identical
> and identically dubious.
>

Do you think the API method to get the current equalizer settings out of
the media player is actually needed?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120821/2c00dc1d/attachment.html>