[vlc-devel] [PATCH 1/3] OS/2: Include sys/types.h in vlc_common.h

Rémi Denis-Courmont remi at remlab.net
Fri Aug 24 17:01:51 CEST 2012


Le vendredi 24 août 2012 17:45:15 KO Myung-Hun, vous avez écrit :
> >> +#ifdef __OS2__
> >> +#   include <sys/types.h>
> >> +#endif
> > 
> > This should be included unconditionally, or if ssize_t is used
> > conditionally, under the same condition.
> 
> Ok, include unconditionally.

Well, I don't mind elevating <sys/types.h> to the same rank of as <inttypes.h> 
and <stdbool.h>. But then all the redundant inclusions should probably be 
removed from the code base...

-- 
Rémi Denis-Courmont
C/C++ software engineer looking for a job
http://www.linkedin.com/in/remidenis



More information about the vlc-devel mailing list