[vlc-devel] [PATCH 1/3] OS/2: Include sys/types.h in vlc_common.h

Måns Rullgård mans at mansr.com
Fri Aug 24 23:54:01 CEST 2012

"Rémi Denis-Courmont" <remi at remlab.net> writes:

> Le vendredi 24 août 2012 17:45:15 KO Myung-Hun, vous avez écrit :
>> >> +#ifdef __OS2__
>> >> +#   include <sys/types.h>
>> >> +#endif
>> > 
>> > This should be included unconditionally, or if ssize_t is used
>> > conditionally, under the same condition.
>> Ok, include unconditionally.
> Well, I don't mind elevating <sys/types.h> to the same rank of as
> <inttypes.h> and <stdbool.h>. But then all the redundant inclusions
> should probably be removed from the code base...

sys/types.h is POSIX while the other two you mention are C99, so there
is a difference there.  However, ssize_t is only specified by POSIX, and
there it is to be defined by sys/types.h.  Hence code using ssize_t not
only can, but should include sys/types.h.

Måns Rullgård
mans at mansr.com

More information about the vlc-devel mailing list