[vlc-devel] [PATCH] Build contribs with debugging symbols

[Rafaël Carré]

Hello,

Le 2012-08-30 12:37, armand bendanan a écrit :
> Hello,
> 
> This break the libgcrypt compile in contrib., as:
> 
> /bin/bash ../libtool --mode=compile --tag=RC i686-w64-mingw32-windres
> -DHAVE_CONFIG_H -I. -I..    -g
> -I/home/share/projets/vlc/workspace/vlc_pcneslog4_git_buildconfig/contrib/i6
> 86-w64-mingw32/include -i "versioninfo.rc" -o "versioninfo.lo"
> libtool: compile:  i686-w64-mingw32-windres -DHAVE_CONFIG_H -I. -I.. -g
> -I/home/share/projets/vlc/workspace/vlc_pcneslog4_git_buildconfig/contrib/i6
> 86-w64-mingw32/include -i versioninfo.rc -o versioninfo.o

I think gcrypt uses CPPFLAGS for this tool (for -D and -I), we should
add -g only to CFLAGS and CXXFLAGS.

Can you try this diff: ?


diff --git a/contrib/src/main.mak b/contrib/src/main.mak
index 2cb7e12..00166f9 100644
--- a/contrib/src/main.mak
+++ b/contrib/src/main.mak
@@ -163,11 +163,10 @@ endif

 cppcheck = $(shell $(CC) $(CFLAGS) -E -dM - < /dev/null | grep -E $(1))

-EXTRA_CFLAGS += -g
 EXTRA_CFLAGS += -I$(PREFIX)/include
 CPPFLAGS := $(CPPFLAGS) $(EXTRA_CFLAGS)
-CFLAGS := $(CFLAGS) $(EXTRA_CFLAGS)
-CXXFLAGS := $(CXXFLAGS) $(EXTRA_CFLAGS)
+CFLAGS := $(CFLAGS) $(EXTRA_CFLAGS) -g
+CXXFLAGS := $(CXXFLAGS) $(EXTRA_CFLAGS) -g
 EXTRA_LDFLAGS += -L$(PREFIX)/lib
 LDFLAGS := $(LDFLAGS) $(EXTRA_LDFLAGS)
 # Do not export those! Use HOSTVARS.


> i686-w64-mingw32-windres: invalid option -- 'g'
> Usage: i686-w64-mingw32-windres [option(s)] [input-file] [output-file]
>  The options are:
>   -i --input=<file>            Name input file
>   -o --output=<file>           Name output file
>   -J --input-format=<format>   Specify input format
>   -O --output-format=<format>  Specify output format
>   -F --target=<target>         Specify COFF target
>      --preprocessor=<program>  Program to use to preprocess rc file
>      --preprocessor-arg=<arg>  Additional preprocessor argument
>   -I --include-dir=<dir>       Include directory when preprocessing rc file
>   -D --define <sym>[=<val>]    Define SYM when preprocessing rc file
>   -U --undefine <sym>          Undefine SYM when preprocessing rc file
>   -v --verbose                 Verbose - tells you what it's doing
>   -c --codepage=<codepage>     Specify default codepage
>   -l --language=<val>          Set language when reading rc file
>      --use-temp-file           Use a temporary file instead of popen to read
>                                the preprocessor output
>      --no-use-temp-file        Use popen (default)
>   -r                           Ignored for compatibility with rc
>   @<file>                      Read options from <file>
>   -h --help                    Print this help message
>   -V --version                 Print version information
> FORMAT is one of rc, res, or coff, and is deduced from the file name
> extension if not specified.  A single file name is an input file.
> No input-file is stdin, default rc.  No output-file is stdout, default rc.
> i686-w64-mingw32-windres: supported targets: pe-i386 pei-i386 elf32-i386
> elf32-little elf32-big plugin srec symbolsrec verilog tekhex binary ihex
> make[2]: *** [versioninfo.lo] Error 1
> make[2]: Leaving directory
> `/home/share/projets/vlc/workspace/vlc_pcneslog4_git_buildconfig/contrib/win
> 32/libgcrypt/src'
> make[1]: *** [install-recursive] Error 1
> make[1]: Leaving directory
> `/home/share/projets/vlc/workspace/vlc_pcneslog4_git_buildconfig/contrib/win
> 32/libgcrypt'
> make: *** [.gcrypt] Error 2
> 
> 
> 
> 
> -----Original Message-----
> From: vlc-devel-bounces at videolan.org [mailto:vlc-devel-bounces at videolan.org]
> On Behalf Of Rafaël Carré
> Sent: mercredi 29 août 2012 15:22
> To: vlc-devel at videolan.org
> Subject: [vlc-devel] [PATCH] Build contribs with debugging symbols
> 
> ---
>  contrib/src/main.mak |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/contrib/src/main.mak b/contrib/src/main.mak index
> e99281d..2cb7e12 100644
> --- a/contrib/src/main.mak
> +++ b/contrib/src/main.mak
> @@ -163,6 +163,7 @@ endif
>  
>  cppcheck = $(shell $(CC) $(CFLAGS) -E -dM - < /dev/null | grep -E $(1))
>  
> +EXTRA_CFLAGS += -g
>  EXTRA_CFLAGS += -I$(PREFIX)/include
>  CPPFLAGS := $(CPPFLAGS) $(EXTRA_CFLAGS)  CFLAGS := $(CFLAGS)
> $(EXTRA_CFLAGS)
> --
> 1.7.10.4
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
> -----
> Aucun virus trouvé dans ce message.
> Analyse effectuée par AVG - www.avg.fr
> Version: 2012.0.2197 / Base de données virale: 2437/5231 - Date: 28/08/2012
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>