[vlc-devel] [PATCH] Build contribs with debugging symbols

[armand bendanan]

> -----Original Message-----
> From: vlc-devel-bounces at videolan.org [mailto:vlc-devel-
> bounces at videolan.org] On Behalf Of Rafaël Carré
> Sent: jeudi 30 août 2012 14:03
> To: Mailing list for VLC media player developers
> Subject: Re: [vlc-devel] [PATCH] Build contribs with debugging symbols
> 
> Hello,
> 
> Le 2012-08-30 12:37, armand bendanan a écrit :
> > Hello,
> >
> > This break the libgcrypt compile in contrib., as:
> >
> > /bin/bash ../libtool --mode=compile --tag=RC i686-w64-mingw32-windres
> > -DHAVE_CONFIG_H -I. -I..    -g
> > -I/home/share/projets/vlc/workspace/vlc_pcneslog4_git_buildconfig/cont
> > rib/i6 86-w64-mingw32/include -i "versioninfo.rc" -o "versioninfo.lo"
> > libtool: compile:  i686-w64-mingw32-windres -DHAVE_CONFIG_H -I. -I..
> > -g
> > -I/home/share/projets/vlc/workspace/vlc_pcneslog4_git_buildconfig/cont
> > rib/i6 86-w64-mingw32/include -i versioninfo.rc -o versioninfo.o
> 
> I think gcrypt uses CPPFLAGS for this tool (for -D and -I), we should add
> -g only to CFLAGS and CXXFLAGS.
> 
> Can you try this diff: ?

Yes I will, but it will take hours, I will put the results here

> 
> 
> diff --git a/contrib/src/main.mak b/contrib/src/main.mak index
> 2cb7e12..00166f9 100644
> --- a/contrib/src/main.mak
> +++ b/contrib/src/main.mak
> @@ -163,11 +163,10 @@ endif
> 
>  cppcheck = $(shell $(CC) $(CFLAGS) -E -dM - < /dev/null | grep -E $(1))
> 
> -EXTRA_CFLAGS += -g
>  EXTRA_CFLAGS += -I$(PREFIX)/include
>  CPPFLAGS := $(CPPFLAGS) $(EXTRA_CFLAGS) -CFLAGS := $(CFLAGS)
> $(EXTRA_CFLAGS) -CXXFLAGS := $(CXXFLAGS) $(EXTRA_CFLAGS)
> +CFLAGS := $(CFLAGS) $(EXTRA_CFLAGS) -g
> +CXXFLAGS := $(CXXFLAGS) $(EXTRA_CFLAGS) -g
>  EXTRA_LDFLAGS += -L$(PREFIX)/lib
>  LDFLAGS := $(LDFLAGS) $(EXTRA_LDFLAGS)
>  # Do not export those! Use HOSTVARS.
>