[vlc-devel] [PATCH] chromaprint: add fingerprinter module

[Francois Cartegnie]

Le 22/11/2012 21:56, Rémi Denis-Courmont a écrit :
> Le jeudi 22 novembre 2012 22:47:50, Francois Cartegnie a écrit :
>> +            mtime_t timeout = mdate() + 50000;
>> +            vlc_mutex_lock( &wait.lock );
>> +            vlc_cond_timedwait( &wait.cond, &wait.lock, timeout );
>> +            vlc_mutex_unlock( &wait.lock );
> 
> Two anti-patterns in four lines. You cannot be serious.
> 

Outside of a difference in the timeout/lock sequence, I don't see
anything wrong according the pthread_cond* doc and related talks.

Francois