[vlc-devel] [PATCH] chromaprint: add fingerprinter module

[Rémi Denis-Courmont]

Le mercredi 5 décembre 2012 21:21:55, Francois Cartegnie a écrit :
> Le 22/11/2012 21:56, Rémi Denis-Courmont a écrit :
> > Le jeudi 22 novembre 2012 22:47:50, Francois Cartegnie a écrit :
> >> +            mtime_t timeout = mdate() + 50000;
> >> +            vlc_mutex_lock( &wait.lock );
> >> +            vlc_cond_timedwait( &wait.cond, &wait.lock, timeout );
> >> +            vlc_mutex_unlock( &wait.lock );
> > 
> > Two anti-patterns in four lines. You cannot be serious.
> 
> Outside of a difference in the timeout/lock sequence, I don't see
> anything wrong according the pthread_cond* doc and related talks.

So... You complain that VLC is not documented but you do not even read the 
documentation when it exists?

-- 
Rémi Denis-Courmont
http://www.remlab.net/