[vlc-devel] [vlc-commits] macosx: fixed subtitle rendering resolution when using the native fullscreen mode (close #7946)
David Fuhrmann
david.fuhrmann at gmail.com
Tue Dec 25 19:59:51 CET 2012
Am 25.12.2012 um 15:25 schrieb Felix Paul Kühne <git at videolan.org>:
> vlc | branch: master | Felix Paul Kühne <fkuehne at videolan.org> | Tue Dec 25 15:25:01 2012 +0100| [ea98fcfc60555b5f06a7149b8142be0bfcfb2be8] | committer: Felix Paul Kühne
>
> macosx: fixed subtitle rendering resolution when using the native fullscreen mode (close #7946)
>
> bug was triggered only when using controls provided by the OS like NSWindow's fullscreen button
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=ea98fcfc60555b5f06a7149b8142be0bfcfb2be8
> ---
> ...
> +- (void)osWillChangeFullScreenStatus:(NSNotification *)notification
> +{
> + playlist_t *p_playlist = pl_Get(VLCIntf);
> + if ([notification.name isEqualToString:@"NSWindowWillEnterFullScreenNotification"] || [notification.name isEqualToString:@"NSWindowDidEnterFullScreenNotification"])
> + var_SetBool(p_playlist, "fullscreen", 1);
> + else
> + var_SetBool(p_playlist, "fullscreen", 0);
Hi Felix,
Are you sure that this is needed? Actually, the playlist fullscreen variable should already be updated in windowWillEnterFullScreen / windowWillExitFullScreen (MainWindow.m line 833 and following).
Best regards,
David
More information about the vlc-devel
mailing list