[vlc-devel] [vlc-commits] macosx: fixed subtitle rendering resolution when using the native fullscreen mode (close #7946)

[Felix Paul Kühne]

Hello David,

On 25.12.2012, at 19:59, David Fuhrmann wrote:

> Are you sure that this is needed? Actually, the playlist fullscreen variable should already be updated in windowWillEnterFullScreen / windowWillExitFullScreen (MainWindow.m line 833 and following).

Well, in fact, the playlist's fullscreen variable is incorrectly set to false without my code, possibly due to some hack in intf.m (setFullScreenForWindow…). However, the important part of my patch isn't about the variable, but the enforced reshape on the VLCOpenGLView hidden within the vout view. Of course, we could do move the code to the main window. However, if you intend to add lion-fullscreen-support for non-main windows, the current location might be more appropriate, since the code is more about the vout view than the window it is in. Philosophical decision, not a technical one. Up to you, since you are taking care of most of the Cocoa vout code nowadays :)

Happy Holiday!

Felix