[vlc-devel] [PATCH 1/1] add bin to PATH to let libvlc.dll be found by vlc-cache-gen.exe

[Rafaël Carré]

Le 2012-02-06 04:20, Rémi Denis-Courmont a écrit :
> On Sat, 4 Feb 2012 19:12:27 +0700, Sergey Radionov <rsatom at gmail.com>
> wrote:
>> 2011/12/25 Sergey Radionov <rsatom at gmail.com>:
>>> Fix "This application has failed to start because libvlc.dll
>>> was not found. Re-installing the application may fix this problem."
>>> during building of vlc under Windows.
>>> ---
>>>  Makefile.am |    1 +
>>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/Makefile.am b/Makefile.am
>>> index 358ac5f..dae8ad1 100644
>>> --- a/Makefile.am
>>> +++ b/Makefile.am
>>> @@ -406,6 +406,7 @@ vlc$(EXEEXT):
>>>
>  ###############################################################################
>>>  install-exec-hook:
>>>        if test "$(build)" = "$(host)"; then \
>>> +               PATH="$(DESTDIR)$(bindir):$$PATH" \
>>>                LD_LIBRARY_PATH="$(DESTDIR)$(libdir):$$LD_LIBRARY_PATH"
> \
>>>                "$(DESTDIR)$(vlclibdir)/vlc-cache-gen$(EXEEXT)" \
>>>                         "$(DESTDIR)$(vlclibdir)/plugins" ; \
>>> --
>>> 1.7.7.1.msysgit.0
>>>
>>
>> ping?
> 
> I think I already mentioned it was wrong. Pinging won't change my mind.

I already applied it, according to

<20120104112301.GA12100 at videolan.org> :
> Both can be argued for, to be honest.
> However, it is true that most setups (including autotools) install
> windows libraries in /bin.

And since it wouldn't harm non-Windows runs