[vlc-devel] [vlc-commits] dxva2: sort Microsoft and extension GUIDs

Rémi Denis-Courmont remi at remlab.net
Mon Feb 6 20:05:51 CET 2012


Le lundi 6 février 2012 09:12:24 Jean-Baptiste Kempf, vous avez écrit :
> On Mon, Feb 06, 2012 at 07:23:10AM +0100, Rafaël Carré wrote :
> > vlc | branch: master | Rafaël Carré <funman at videolan.org> | Mon Feb  6
> > 01:22:43 2012 -0500| [b2ded57a1525cb0c0b7a6a07808b07942899564d] |
> > committer: Rafaël Carré
> > 
> > dxva2: sort Microsoft and extension GUIDs
> 
> There were sorted by codec, for a reason...
> This is now more difficult to see at a quick glance.

I don't have an opinion on this particular case. But if you use a particular 
non-obvious sorting logic, you should document it at the top with a comment.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis



More information about the vlc-devel mailing list