[vlc-devel] [vlc-commits] dxva2: sort Microsoft and extension GUIDs

[Jean-Baptiste Kempf]

On Mon, Feb 06, 2012 at 09:05:51PM +0200, Rémi Denis-Courmont wrote :
> Le lundi 6 février 2012 09:12:24 Jean-Baptiste Kempf, vous avez écrit :
> > On Mon, Feb 06, 2012 at 07:23:10AM +0100, Rafaël Carré wrote :
> > > vlc | branch: master | Rafaël Carré <funman at videolan.org> | Mon Feb  6
> > > 01:22:43 2012 -0500| [b2ded57a1525cb0c0b7a6a07808b07942899564d] |
> > > committer: Rafaël Carré
> > > 
> > > dxva2: sort Microsoft and extension GUIDs
> > 
> > There were sorted by codec, for a reason...
> > This is now more difficult to see at a quick glance.
> 
> I don't have an opinion on this particular case. But if you use a particular 
> non-obvious sorting logic, you should document it at the top with a comment.

The guid were grouped by codecs. It made sense.

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device