[vlc-devel] [vlc-commits] DXVA2_ModeVC1_D2010 is specified by Microsoft

[Rafaël Carré]

Le 2012-02-06 18:55, Jean-Baptiste Kempf a écrit :
> On Mon, Feb 06, 2012 at 06:51:35PM -0500, Rafaël Carré wrote :
>> Le 2012-02-06 18:49, Jean-Baptiste Kempf a écrit :
>>> On Mon, Feb 06, 2012 at 06:47:54PM -0500, Rafaël Carré wrote :
>>>> Le 2012-02-06 18:44, Jean-Baptiste Kempf a écrit :
>>>>> On Tue, Feb 07, 2012 at 12:28:46AM +0100, Rafaël Carré wrote :
>>>>>> vlc | branch: master | Rafaël Carré <funman at videolan.org> | Mon Feb  6 16:19:09 2012 -0500| [08973b65ec3b7dab6f316454105fa53b345cb015] | committer: Rafaël Carré
>>>>>>
>>>>>> DXVA2_ModeVC1_D2010 is specified by Microsoft
>>>>>
>>>>> And I object once again.
>>>>> Please go back to the version from 454ef7 and add the ifdef you need
>>>>> around the parts that you need for mingw64.
>>>>>
>>>>> But, keep the list ordered and grouped by codecs as it make sense.
>>>>
>>>>
>>>>
>>>>
>>>>> Ordering by "mingw64 header v2.0.0 has it or not" make little sense.
>>>>
>>>> Ordering by "Microsoft SDK has it or not" makes sense.
>>>
>>> And how would you know that if you refuse to read the SDK?
>>> And what version of the SDK? 7.1? 8.0? 64bits or 32bits? Win32 or WinRT?
>>
>> http://msdn.microsoft.com/en-us/library/windows/desktop/ms697067(v=vs.85).aspx
>> answers all your questions.
> 
> It does not:
> http://msdn.microsoft.com/en-us/library/windows/desktop/cc307941%28v=vs.85%29.aspx
> says different things, as I already told you.
> And those:
> http://www.microsoft.com/download/en/details.aspx?id=25200
> http://www.microsoft.com/download/en/details.aspx?id=21100
> http://www.microsoft.com/download/en/details.aspx?displaylang=en&id=11323
> http://www.microsoft.com/download/en/details.aspx?displaylang=en&id=25228
> 
> Also defines GUID, and since those extensions are post WinSDK 7, they
> cannot be defined in the Vista DxVA2api.h nor the 7 one.
> 
> And that would be exactly the same for this very commit that has
> DXVA2_ModeVC1_D2010 in it...

You're right it can not.

Thus this commit is wrong, for the reasons you told in your 4th email,
not counting answers to my previous commits.

Please calm down and stop jumping at my throat like I'm trying to defeat
your work or something, because that is not the case.


I grouped them by GUIDs defined in dxva2api.h, to properly ifdef them
out when mingw-w64 gets a proper header.

One will then be able to build this particular module against Microsoft
headers, I don't think anything forbids that.

I don't intend to redistribute (parts of) VLC built with non-free
software but it would clearly help seeing if this software obtained
through reverse engineering is correct.



I still don't know for which purpose this apparently unordered list was
sorted by codec type.

dxva2_modes, the list using those GUIDs and associating them with
description, AND CODEC is already obviously sorted.

What are you trying to guess from the GUIDs themselves?