[vlc-devel] [vlc-commits] Add lua console handling code for windows.

[Rémi Denis-Courmont]

Le mercredi 8 février 2012 14:46:26 Antoine Cellerier, vous avez écrit :
> > Maybe. But the timeouts are exposed to Lua, and Lua gets some Windows
> > only code. This is not a good example, nor a good design. As a matter of
> > fact, I have not had much help with event handling ever since Zorglub
> > left.
> 
> I'd rather have questionable design with working functionality than
> correct design and non-functional code. At least we have something that
> works now which can be used to move forward.

I'd rather have no functionality than incorrect code. In open-source in 
general and VLC especially, refusing to merge (or threatening to remove) bad 
code is more or less the only way to get people to fix their code.

But fine. Go ahead. I disclaim all responsibility with regards to removing the 
code, breaking its compilation, its linking or its functionality in the 
future, without warning, should it make my life easier when implementing, 
fixing or cleaning up something (else). If the author does not fix his own 
code, why should I care? I don't think that would be for the better of the 
project though.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis