[vlc-devel] [PATCH] Updates theora to use the new API instead of the deprecated one and fixes a crash on playback.
theron at bittorrent.com
Fri Feb 10 22:22:36 CET 2012
On Fri, Feb 10, 2012 at 1:07 PM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> Is this the infamous theora crash on win32?
Yes it is. :)
>> + p_sys->tcx = NULL;
I'll fix these. My emacs editor is set to a different indentation style.
> Do we really need ALL those asserts?
Not really. These were more for my benefit when I was trying to find
a bug and I left them in because I thought they did a good job
documenting the restrictions on these fields. I will remove them. It
will be cleaner.
> Defining MIN is not ok. Use __MIN
Good point. I'll fix it.
>> + /* if( theora_decode_header( &p_sys->ti, &p_sys->tc,
>> &oggpacket ) < 0 ) */
>> + if( th_decode_headerin( &p_sys->ti, &p_sys->tc, &ts, &oggpacket ) < 0 )
> Why keeping the commented code?
I missed that. I'll clean that up.
Should I submit the updated patch to the same thread?
More information about the vlc-devel