[vlc-devel] [PATCH] Updates theora to use the new API instead of the deprecated one and fixes a crash on playback.

Jean-Baptiste Kempf jb at videolan.org
Fri Feb 10 22:28:51 CET 2012

On Fri, Feb 10, 2012 at 01:22:36PM -0800, Theron Lewis wrote :
> On Fri, Feb 10, 2012 at 1:07 PM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> >[...]
> > Is this the infamous theora crash on win32?
> Yes it is. :)

Then your commit log should have "Close #3841" in it.

> I'll fix these.  My emacs editor is set to a different indentation style.

Use vim... mwhahahah

> > Do we really need ALL those asserts?
> Not really.  These were more for my benefit when I was trying to find
> a bug and I left them in because I thought they did a good job
> documenting the restrictions on these fields.  I will remove them.  It
> will be cleaner.

Don't remove all of them, just keep the ones that really make sense.

> Should I submit the updated patch to the same thread?

As you wish, seriously.

Best regards,

Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device

More information about the vlc-devel mailing list