[vlc-devel] [PATCH] Use newer theora API and fix windows crash (Close #3841)

Theron Lewis theron at bittorrent.com
Sat Feb 11 01:13:38 CET 2012

On Fri, Feb 10, 2012 at 3:37 PM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> [...]

>> +    /* turn on fast encoding */
> Why?

The original code set the following:

p_sys->ti.quick_p = 1;

That turns on fast encoding in the old API.  I was just attempting to
reproduce the same behavior using the current API. I can take this out
if you think the default would be better.

> Did you check that we pass the theora test-suite with this?

I tested this against several theora videos we have that crashed vlc
before the update but not against the test suite.

I will fix the other issues and run a build against the test suite and
submit the 2nd patch.


More information about the vlc-devel mailing list