[vlc-devel] [PATCH] Use newer theora API and fix windows crash (Close #3841)

[Jean-Baptiste Kempf]

On Fri, Feb 10, 2012 at 04:13:38PM -0800, Theron Lewis wrote :
> On Fri, Feb 10, 2012 at 3:37 PM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> > [...]
> 
> >> +    /* turn on fast encoding */
> >
> > Why?
> 
> The original code set the following:
> 
> p_sys->ti.quick_p = 1;
> 
> That turns on fast encoding in the old API.  I was just attempting to
> reproduce the same behavior using the current API. I can take this out
> if you think the default would be better.

No, you are right, in maintaining compat.

> I tested this against several theora videos we have that crashed vlc
> before the update but not against the test suite.

I was mostly thinking about that one:
http://v2v.cc/~j/theora_testsuite/offset_test.ogv

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device