[vlc-devel] [PATCH] Use newer theora API and fix windows crash (Close #3841)

Jean-Baptiste Kempf jb at videolan.org
Sat Feb 11 02:26:06 CET 2012

On Fri, Feb 10, 2012 at 05:17:45PM -0800, Theron Lewis wrote :
> On Fri, Feb 10, 2012 at 5:10 PM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> >
> > Please squash those 2 patches (git rebase -i origin/naster is awesome if
> > you don't know about it).
> Attached.

Seems mostly fine for me.

Be careful for wrapping long lines.
And I am not too sure about the memcpy part, but Ogg comments are so
brain-dead that this might be the only sane way of doing it.

> You're right, git rebase -i origin/master *IS* awesome!  Thanks!

OT: Do you know about git commit -p and git commit -i ?

Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device

More information about the vlc-devel mailing list