[vlc-devel] [PATCH] Use newer theora API and fix windows crash (Close #3841)

[Kaarlo Räihä]

11. helmikuuta 2012 3.26 Jean-Baptiste Kempf <jb at videolan.org> kirjoitti:

> On Fri, Feb 10, 2012 at 05:17:45PM -0800, Theron Lewis wrote :
> > On Fri, Feb 10, 2012 at 5:10 PM, Jean-Baptiste Kempf <jb at videolan.org>
> wrote:
> > >
> > > Please squash those 2 patches (git rebase -i origin/naster is awesome
> if
> > > you don't know about it).
> >
> > Attached.
>
> Seems mostly fine for me.
>

This IMHO is definitely NEWSworthy since many people have complained about
Theora crashes.


>
> Be careful for wrapping long lines.
> And I am not too sure about the memcpy part, but Ogg comments are so
> brain-dead that this might be the only sane way of doing it.
>
> > You're right, git rebase -i origin/master *IS* awesome!  Thanks!
>
> OT: Do you know about git commit -p and git commit -i ?
>
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/ - +33 672 704 734
> Sent from my Electronic Device
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120211/600e71ba/attachment.html>