[vlc-devel] Bug with playback menu in HEAD

[Juha Jeronen]

Hi all,

Commit [921a659cf599ac0afd943aeed0a4fc085cc4f24f] is the culprit. The
version from the previous commit
[06ca7e5db55f291040b577b7fcdcf95d6bc514a4] works fine. I git-cleaned the
source tree both times before build, so this information should be reliable.

Note that 2.0 is fine, and only 2.1-git is affected.

Git log says:

---8<---8<---8<---

commit 921a659cf599ac0afd943aeed0a4fc085cc4f24f
Author: Jean-Baptiste Kempf <jb at videolan.org>
Date:   Sat Jan 14 07:03:38 2012 +0100

    Qt: rebuild correctly the playback menu
   
    And also, close #5522

---8<---8<---8<---

I tried looking at the code and specifically RebuildNavigMenu() (in
modules/gui/qt4/menus.cpp), but I could use some help here (specifically
from j-b :) )


To reproduce the issue, open a file in VLC, and while it's playing, keep
clicking the Playback menu to open it again and again. The
Play/Stop/Next/Previous entries will get duplicated each time (after the
first) when the menu opens.

-J


On 09/02/12 04:30, Juha Jeronen wrote:
> Hi all,
>
> Found some issues in the QT interface of 2.1-git
> [f111847917894e8e5e832a5e2b850d229a4ceebc] while testing my translation.
> One is a bug (described here); I'll post a separate message on
> untranslatable UI strings.
>
> The bug is that if a media is playing, and you click on the Playback
> menu, the menu items Pause/Stop/Previous/Next become duplicated. They
> appear as many times in the menu as how many times you have opened the
> menu. It seems the menu content is rebuilt on the fly, but old items are
> not getting deleted correctly? (Tested with a DVD image.)
>
>  -J
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel