[vlc-devel] [PATCH]Equalizer, support other sampling rates than 44100 and 48000

[Kaarlo Räihä]

21. helmikuuta 2012 11.35 Jean-Baptiste Kempf <jb at videolan.org> kirjoitti:

> On Mon, Feb 20, 2012 at 10:51:51PM -0600, Ron Wright wrote :
> > All right, it seems that all issues have been resolved (except for one).
> > There is no mention of Winamp anywhere, doubles have been changed to
> > floats, the method of creating the "equalizer-classicvlcfreqs" parameter
> is
> > explicitly set to inherit, the return value VLC_SUCCESS has been added to
> > the classic VLC frequency callback function, and C99-style declarations
> are
> > used in the "for" loops.
>
> I think you should use var_InheritInteger and not Create+Get
>
>
> > However, I have two possibilities here:  should
> > the "Use Classic VLC Frequency Bands" checkbox be placed beside the
> > "Enable" and "2 Pass" checkbox at the cost of a wider window (version 1
> > patch), or should it be placed below the frequency adjustment sliders at
> > the cost of a taller window (version 2 patch)?
>
> First, this should be split from the patch.
> Then, does it make any sense to change it live, outside of preferences?
> Do people change that often of bands?
>
>
I personally like it live since it is much easier to hear the differences.


> Best regards,
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/ - +33 672 704 734
> Sent from my Electronic Device
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120221/67b4790f/attachment.html>