[vlc-devel] [PATCH]Equalizer, support other sampling rates than 44100 and 48000

[Ron Wright]

Here, I am trying out both suggestions:  removing the checkbox from the GUI
and replacing Create+Get with var_InheritInteger.  However, I have a
problem.  Using var_InheritBool instead of Create+Get actually causes the
frequency bands to change when stopping a file and playing it back again
after changing the value in the Preferences window.  This approach proved
very difficult, since I could not find a way to update the frequency labels
in the GUI when VLC enters the "playing" state.  (I tried to implement
several different callbacks in the extended_panels.cpp file with no
success.)  Using the older approach of obtaining the variables (Create+Get)
works, since it requires the user to restart the application, making the
implementation in the GUI easier.  At this point, I am stuck, since it is
undesirable to have incorrect frequency bands in the GUI and it is also
undesirable to use Create+Get.

On Tue, Feb 21, 2012 at 3:35 AM, Jean-Baptiste Kempf <jb at videolan.org>wrote:

> On Mon, Feb 20, 2012 at 10:51:51PM -0600, Ron Wright wrote :
> > All right, it seems that all issues have been resolved (except for one).
> > There is no mention of Winamp anywhere, doubles have been changed to
> > floats, the method of creating the "equalizer-classicvlcfreqs" parameter
> is
> > explicitly set to inherit, the return value VLC_SUCCESS has been added to
> > the classic VLC frequency callback function, and C99-style declarations
> are
> > used in the "for" loops.
>
> I think you should use var_InheritInteger and not Create+Get
>
>
> > However, I have two possibilities here:  should
> > the "Use Classic VLC Frequency Bands" checkbox be placed beside the
> > "Enable" and "2 Pass" checkbox at the cost of a wider window (version 1
> > patch), or should it be placed below the frequency adjustment sliders at
> > the cost of a taller window (version 2 patch)?
>
> First, this should be split from the patch.
> Then, does it make any sense to change it live, outside of preferences?
> Do people change that often of bands?
>
> Best regards,
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/ - +33 672 704 734
> Sent from my Electronic Device
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120222/304f4fa2/attachment.html>