[vlc-devel] [vlc-commits] VLM: use custom reference count instead of object destructor

[Sébastien Escudier]

Pierre Ynard wrote
        > vlc | branch: master | Rémi Denis-Courmont <remi at
        remlab.net> | Tue
        > Jul  5 18:09:04 2011 +0300| [71adf301e50aef185ef903d542896071f78323ff] |
        > committer: Rémi Denis-Courmont
        > 
        > VLM: use custom reference count instead of object destructor
        > 
        > This should fix a crash whereby VLM is deleted before its child
        > VOD server object.
        
        > +    if( --p_vlm->users == 0 )
        > +    {
        > +        assert( libvlc_priv(p_vlm->p_libvlc)->p_vlm = p_vlm );
        > +        libvlc_priv(p_vlm->p_libvlc)->p_vlm = NULL;
        > +    }
        
        I think this triggers the assertion in InputEvent(), because it is
        called during the media clean-up which is now done after setting p_vlm
        to NULL.
        
        
What do you think of this patch, to fix this bug ?

Regards,
Sébastien.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-dereference-p_libvlc-p_vlm-after-the-media-clean-up.patch
Type: text/x-patch
Size: 1328 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120221/95b2bc23/attachment.bin>