[vlc-devel] [PATCH 0/2] 10-bit h264 encoding alongside normal libx264

[Ilkka Ollakka]

On Mon, Feb 27, 2012 at 04:36:02PM +0200, Rémi Denis-Courmont wrote:
>    Hello,

Hi,

thanks for review

> On Tuesday 21 February 2012, Ilkka Ollakka wrote:
> > Patch adds hack to contribs for compiling static libx264 in 10-bit encoding
> > under a name libx26410b. Second patch adds x26410b named encoding module
> > to produce 10-bit encodes (and only 10-bit).

> > These allow to have 8-bit and 10-bit x264 libraries in use at the same
> > time. Not sure if this is the best way to archive this functionality so
> > comments are welcome.

> In principles, this seems correct to me, as far as x264 does not support run-
> time selection of bit depth.

> But:
> * I think it will not work with dynamic linking due to conflicting unversioned 
> symbols, 

Yes, I don't think it will work with dynamic linking at all, and it
should be used only in contrib and static module.

> * I think it is quite bold for VLC to invent its own .pc file name on behalf of 
> x264. Maybe the x264 guys should be involved.

Yes, it is somewhat bold. But I don't think it is that big of an issue
as x264 don't have a way to separate 8-bit and 10-bit builds in
.pc-files currently or have them both installed in same time.

I did ask quickly from x264 people if they had any plans to ideas for
that, but nothing came up and I thought that as long as I don't actually
break any systemwide installation stuff, it should be kinda ok.

-- 
Ilkka Ollakka
This fortune is false.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120227/d3d6edc4/attachment.sig>