[vlc-devel] Lua extension and vlc.misc

Jean-Baptiste Kempf jb at videolan.org
Tue Feb 28 21:29:44 CET 2012


On Tue, Feb 28, 2012 at 10:24:24PM +0200, Rémi Denis-Courmont wrote :
> > version() for debugging and for testing if required version is present.
> 
> If Pierre is right, checking for nil is a lot better and more likely to be 
> forward compatible.

True. But it does not hurt to keep it with a warning about deprecation.

> > copyright() for debugging.
> I don't see how copyright is relevant to debug.

I am stating what is used.
It does not hurt to keep it with a warning about deprecation.

> > mdate() for debugging callbacks.
> 
> Whatever. mdate() is not a problem.

Ok.

> But mwait() is a problem and they are 
> tightly coupled.

And sometimes not.

> > mwait() for doing a sleep/poll.
> 
> That sucks in many ways. Normally callbacks should be used. If a timer is 
> really needed (e.g. network polling, playback progress bar), the plugin should 
> be an interface, not an extension. Then the core will know better how to deal 
> with it.

Yes, that should be removed and I'll help the 4 extensions writer to fix
their code. I am surprised it was even exposed at the first place.

To me, the first 3 can be kept with a deprecation warning.
The mwait should be removed.
The cache folder needs a solution.

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device



More information about the vlc-devel mailing list