[vlc-devel] [PATCH 2/2] LUA: AirPlay target support

[Pierre Ynard]

Hello,

> @@ -123,6 +123,12 @@ static char *MakeConfig( intf_thread_t *p_intf, const char *name )
>              free( psz_rc_host );
>          }
>      }
> +#ifdef __APPLE__
> +    else if( !strcmp( name, "airplay" ) )
> +    {
> +        asprintf( &psz_config, "airplay" );
> +    }
> +#endif

I fail to see what this achieves. MakeConfig() is useful for including
configuration variables into the lua script config, but apparently you
have none.

> +#ifdef __APPLE__
> +    add_submodule ()
> +        set_section( N_("Lua AirPlay"), 0 )
> +        set_capability( "interface", 0 )
> +        set_callbacks( Open_LuaAirplay, Close_LuaIntf )
> +        set_description( N_("Lua AirPlay") )
> +        add_shortcut( "luaairplay", "airplay" )
> +#endif

I don't think that the lua-prepended shortcut "luaairplay" is very
useful for a novelty.

> +--[==========================================================================[
> +Configuration options:
> + * none (port must be passed as a command-line argument to VLC)
> +--]==========================================================================]
> [...]
> +if config then
> +    if config.host then
> +        vlc.msg.err("\""..config.host.."\" HTTP host ignored")
> +        local port = string.match(config.host, ":(%d+)[^]]*$")
> +        vlc.msg.info("Pass --http-host=IP "..(port and "and --http-port="..port.." " or "").."on the command line instead.")
> +    end
> +end

This is useless since you have no config variable (and never had any
since the script is new).

Also what does this interface do exactly? I haven't had time to read it
all but I share Rémi's concerns about expanding the lua API.

Regards,

-- 
Pierre Ynard
"Une âme dans un corps, c'est comme un dessin sur une feuille de papier."