[vlc-devel] [PATCH] Don't assume O_CLOEXEC is defined

[Rafaël Carré]

Le 2012-01-04 14:23, Rémi Denis-Courmont a écrit :
> Le mercredi 4 janvier 2012 21:15:33 Rafaël Carré, vous avez écrit :
>> Le 2012-01-04 14:14, Rémi Denis-Courmont a écrit :
>>> Bugged.
>>
>> What does this mean?
> 
> I think this is rather obvious, but setting the close-on-exec flag is not 
> (only) done for the sake of artistic beauty.

Yeah I know, I have read about what this flag does.

I stole the code from (your?) posix/filesystem.c

> Besides, O_CLOEXEC is older than Linux DVBv5 which the plugin requires, so it 
> seems rather pointless.

http://buildbot.videolan.org/builders/i686-freebsd8/builds/4/steps/Compile/logs/stdio

I notice
dtv/linux.c:905:3: warning: #warning DVB-T2 needs Linux DVB version 5.3
or later.

But it's a warning