[vlc-devel] [PATCH] Don't assume O_CLOEXEC is defined

[Rafaël Carré]

Le 2012-01-04 14:28, Rafaël Carré a écrit :
> Le 2012-01-04 14:23, Rémi Denis-Courmont a écrit :
>> Le mercredi 4 janvier 2012 21:15:33 Rafaël Carré, vous avez écrit :
>>> Le 2012-01-04 14:14, Rémi Denis-Courmont a écrit :
>>>> Bugged.
>>>
>>> What does this mean?
>>
>> I think this is rather obvious, but setting the close-on-exec flag is not 
>> (only) done for the sake of artistic beauty.
> 
> Yeah I know, I have read about what this flag does.
> 
> I stole the code from (your?) posix/filesystem.c

So this is Linux/glibc only (Drepper's invention)

Perhaps it could go in vlc_fs.h as
#ifndef O_CLOEXEC
# define O_CLOEXEC 0
#endif

>> Besides, O_CLOEXEC is older than Linux DVBv5 which the plugin requires, so it 
>> seems rather pointless.

Do we require "a certain version of glibc which has O_CLOEXEC" ?