[vlc-devel] [PATCH] Don't assume O_CLOEXEC is defined

[Rémi Denis-Courmont]

Le mercredi 4 janvier 2012 23:18:57 Rafaël Carré, vous avez écrit :
> > I stole the code from (your?) posix/filesystem.c
> 
> So this is Linux/glibc only

That is not true:
http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/fcntl.h.html

Besides, where something originates from is irrelevant. uselocale() is a MacOS 
invention and openat() comes from Solaris. We still use them because they are 
useful.

> (Drepper's invention)

Possibly so. The guy does have some clue about POSIX.

> Perhaps it could go in vlc_fs.h as
> #ifndef O_CLOEXEC
> # define O_CLOEXEC 0
> #endif
> 
> >> Besides, O_CLOEXEC is older than Linux DVBv5 which the plugin requires,
> >> so it seems rather pointless.
> 
> Do we require "a certain version of glibc which has O_CLOEXEC" ?

Linux support for close-on-exec is in the kernel, not libc. And that is 
irrelevant. What is relevant is your patch brings back a well-known annoying 
old bug, leaking of device nodes through child processes.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis