[vlc-devel] [PATCH] Fixed a crash caused by yadif deinterlacer on Windows XP

Naohiro KORIYAMA nkoriyama at gmail.com
Sat Jan 7 12:43:25 CET 2012


I did incorrect modification moving [16] out of DECLARE_ALIGNED(),
and it caused a crash.

Fixes #5793.

---
 modules/video_filter/deinterlace/yadif_template.h |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/modules/video_filter/deinterlace/yadif_template.h
b/modules/video_filter/deinterlace/yadif_template.h
index 146b301..de6bb4a 100644
--- a/modules/video_filter/deinterlace/yadif_template.h
+++ b/modules/video_filter/deinterlace/yadif_template.h
@@ -110,10 +110,10 @@ VLC_TARGET static void
RENAME(yadif_filter_line)(uint8_t *dst,
                               uint8_t *prev, uint8_t *cur, uint8_t *next,
                               int w, int prefs, int mrefs, int
parity, int mode)
 {
-    DECLARE_ALIGNED(16, uint8_t, tmp0)[16];
-    DECLARE_ALIGNED(16, uint8_t, tmp1)[16];
-    DECLARE_ALIGNED(16, uint8_t, tmp2)[16];
-    DECLARE_ALIGNED(16, uint8_t, tmp3)[16];
+    DECLARE_ALIGNED(16, uint8_t, tmp0[16]);
+    DECLARE_ALIGNED(16, uint8_t, tmp1[16]);
+    DECLARE_ALIGNED(16, uint8_t, tmp2[16]);
+    DECLARE_ALIGNED(16, uint8_t, tmp3[16]);
     int x;

 #define FILTER\
-- 
1.7.7.2



More information about the vlc-devel mailing list