[vlc-devel] [PATCH] Fixed a crash caused by yadif deinterlacer on Windows XP

[Naohiro KORIYAMA]

Hello,

2012/1/10 Rafaël Carré <funman at videolan.org>:
> Le 12-01-09 11:29, Naohiro KORIYAMA a écrit :
>> I made a patch for Mac OS X and FreeBSD 32bit builds.
>>
>> Only on win32 builds, use manual alignment.
>> On other builds, use gcc's attribute aligned.
>
> Did you reproduce the win32 crash with your own build?
> Did you try with nightly build version?

Latest win32 nightly builds doesn't crash on Windows XP 32bit
because of the commit 577b183d295adbea85e03502d73d04fd3f90ef90.
Before that commit, both nightly builds and my own builds crash on Windows XP.
I didn't notice the crash before user report, because I didn't use
win32 build on
Windows XP, and win32 build didn't crash on Windows 7 64bit.

> Which version of gcc do you use in your own build?

4.6.2 and 4.6.3(prerelease) with mingw.

> Laurent says ffmpeg use attribute aligned (teh same DECLARE_ALIGNED
> macro) a lot of times and it works fine.

Yes. It should work. But win32 builds on Windows XP, it (or other
place) have a problem.

-- 
KORIYAMA, Naohiro
nkoriyama at gmail.com