[vlc-devel] [PATCH] Small change to let other keyboard layouts have hotkeys

[Rémi Denis-Courmont]

Le mercredi 11 janvier 2012 20:20:27 Militaru Cristian, vous avez écrit :
> I don't think that matters.

It does matter. First, it affects how the key is represented in the VLC 
configuration subsystem. Second, Qt is not the only source of keys, and all 
sources obviously need to agree on the key symbols.

> I mean, I guess vlc doesn't have its own hotkey processing,

Of course it does. Otherwise, there would be no need for the function that 
your patch attempts to modify in the first place.


And for the record, the VLC key symbols are currently defined as follow:

(1) If the key, as defined by the X11 standard, represents a Unicode 
character, then the VLC key symbol is the corresponding Unicode code point.

(2) Otherwise, if the key is defined in <vlc_keys.h>, then that is it. Those 
definitions are outside the Unicode range, but below than 2^24.

(3) Otherwise the key is not supported.

(4) Key modifiers use dedicated higher-order bits 24-31.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis