[vlc-devel] [vlc-commits] Fix MacOS build

[Rafaël Carré]

Le 2012-01-25 03:08, Rémi Denis-Courmont a écrit :
> On Tue, 24 Jan 2012 14:41:31 -0500, Rafaël Carré <funman at videolan.org>
> wrote:
>> Le 2012-01-24 14:05, Rémi Denis-Courmont a écrit :
>>> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Tue Jan
>>> 24 21:05:22 2012 +0200| [f6587cd61c91fbc3ec8fc055ee907df17bd30b2a] |
>>> committer: Rémi Denis-Courmont
>>>
>>> Fix MacOS build
>>
>> Aaaah I finally see that you are using the build system, nice to see
> that
>> ;)
> 
> What is that for an attitude? Evidently you refuse to adopt sane and
> cooperative development practices.

Sorry? You have said enough times that you ignore the buildbot and
"broken platforms" that i'm really happy you use it.

> This patch modified code paths on five different platforms (Darwin, Linux,
> OS/2, Windows and the rest), including both revectoring and real code
> changes. There is no way that I can test all platforms, especially
> platforms that cannot be cross-compiled to (namely MacOS). I did test it on
> Linux (test suite + smoke test) and Windows. I did retest it after rebasing
> on top of the changes made by others while writing the patch. And it took a
> long time because of the build system churn.
> 
> I do still make mistakes (e.g. poll), but I do not recall so many
> complaints about my changes as yours, neither in absolute nor in relative
> numbers.

Yes it's difficult/impossible to test everywhere and buildbot is there
to help .. i wanted to add more platforms so breakage (easy to do) is
rapidly detected.


Honestly I was happy you did that mistake but I didn't brag about it or
blamed you personally.

Because honestly I have had my share of retaliation for breaking the
build and the habits but now the things I made stabilized a bit and I am
happy about it; and it's nice to see that I am not the only one who
makes errors and get bugged about it.

> You however have:

> did lot of mistakes in code and bad behaviour on irc and mailing list

agree

> - called me "bitch" on this mailing list,
> - never apologized for doing so,

i guess now we're even, i did not count the number of insults i received
from you on irc or on mailing list recently..

> - committed patches that were rejected,
> - ignored mailing review comments,

dude in the patches i sent recently the impression i have is you talk
about something else just because it's me. You're not even saying it's
rejected you talk about "complete crap", "nothing to do with vlc", "fork
your own";
not only for me but also for sergey who spent time re-sending patches to
build with VC++. Yeah VC++ is perhaps crap and there are GPL issues to
be aware of but you don't seem to respect the time he spent on his work.

> Oh of course as the most noisy person around here, I am the one to
> complain the most about your attitude. But I am NOT the only one having
> problems. If you refuse to change your attitude, then you really should
> leave the project for real this time. Your behaviour over the last few
> months is not worthy of someone with commit rights.

I don't maintain a list of what you did wrong but there are too in your
attitude things that I don't like and that other people in the project
don't like.

But I think it's not that a big deal. Yeah bad things happen, bad words
are written, but the project moves forward and it is always a pleasure
for me to meet other developers at VDD.
In fact I was eager to go to LA with you so we could meet in more
pleasing conditions than the internet and things would relax a bit but
it's a shame I could not go.

I am certainly not perfect and deserve blame but I will not let you
alone blame me with your condescending attitude.


I don't think any of us leaving the project is something good or even
needed and it's certainly not what I want.


Now that you opened the bag of snakes if other contributors want to tell
me that I suck I will read without arguing (too much. i'll try.)