[vlc-devel] [PATCH 6/8] Include 'unistd.h' for 'ssize_t' on OS/2

[Rémi Denis-Courmont]

Le samedi 28 janvier 2012 18:15:34 Rafaël Carré, vous avez écrit :
> Le 2012-01-28 11:10, Rémi Denis-Courmont a écrit :
> > Le samedi 28 janvier 2012 15:42:04 KO Myung-Hun, vous avez écrit :
> >> ---
> >> 
> >>  include/vlc_block.h |    2 ++
> >>  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > I suspect this breaks some platforms.
> 
> We could commit and let our super build system tell us which platforms
> break

The build bots were deployed to detect unintended errors, not to introduce 
errors and see what happens. Lots of people pull vlc.git. It should not be 
broken on purpose for the convenience of a single developer.



Besides, I don't like to include lots of headers within headers. It makes code 
sloppier over time and compilation slower.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis