[vlc-devel] [PATCH 6/8] Include 'unistd.h' for 'ssize_t' on OS/2

[Rafaël Carré]

Le 2012-01-28 11:34, Rémi Denis-Courmont a écrit :
> Le samedi 28 janvier 2012 18:15:34 Rafaël Carré, vous avez écrit :
>> Le 2012-01-28 11:10, Rémi Denis-Courmont a écrit :
>>> Le samedi 28 janvier 2012 15:42:04 KO Myung-Hun, vous avez écrit :
>>>> ---
>>>>
>>>>  include/vlc_block.h |    2 ++
>>>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> I suspect this breaks some platforms.
>>
>> We could commit and let our super build system tell us which platforms
>> break
> 
> The build bots were deployed to detect unintended errors, not to introduce 
> errors and see what happens. 

What the bots were deployed for does not matter, we can use as a tool
for whichever purpose we want.

Nothing is stopping me to do cooking with a screwdriver if I'd like to,
or break eggs with a hammer.

It's the same for that buildbot tool.

I'm not trying to say it's MY tool though, but trying to add a new tool
to benefit the team.

Your suggestions are welcome about it

> Lots of people pull vlc.git.

You're right.

How about this:

git commit 'some test'
git push
git reset --hard HEAD^
... wait for buildbot to kick in
git push --force

This (ab)uses 2 parts of the system, but in the end:
- the repo is clean
- the commit has been tested



To use it more frequently though, we could use an extra repo (vlc-test?,
vlc-buildtest?) which syncs from vlc.git and which is meant to be
rebased (so we can push all sort of crap in it).

Any commit in this repo would trigger a buildbot round.
Anything committed there would be for example erased at the next vlc.git
commit.


> It should not be
> broken on purpose for the convenience of a single developer.

Well we could do something for the convenience of KO

> Besides, I don't like to include lots of headers within headers. It makes code 
> sloppier over time and compilation slower.

Ok