[vlc-devel] [PATCH]Change read to fstat

Rafaël Carré funman at videolan.org
Sun Jan 29 22:04:06 CET 2012

Le 2012-01-29 13:25, Kaarlo Räihä a écrit :
> 2012/1/29 Rémi Denis-Courmont <remi at remlab.net>
>> Le dimanche 29 janvier 2012 18:13:00 Kaarlo Räihä, vous avez écrit :
>>> I noticed modules/access/file.c has two parts which have msg_Err
>> (p_access,
>>> "failed to read (%m)"); (lines 187 and 297). In yearly years this wasn't
>>> issue since it also printed the function name (access_file error:
>>> fstat(3):) but now it is just filesystem error:
>> fstat is not a verb. I think this patch makes the error harder rather than
>> easier to understand.
> I was under impression that read in this case refers to the function name
> that is called earlier (line 286) not the verb. But I can resend as fstat
> -> open if you prefer it.

open looks better, or perhaps "fstat() failed: %m" ?

It's debug messages so no need to be shakespearian english :)

More information about the vlc-devel mailing list