[vlc-devel] [PATCH]Change read to fstat

[Rémi Denis-Courmont]

Le dimanche 29 janvier 2012 23:04:06 Rafaël Carré, vous avez écrit :
> Le 2012-01-29 13:25, Kaarlo Räihä a écrit :
> > 2012/1/29 Rémi Denis-Courmont <remi at remlab.net>
> > 
> >> Le dimanche 29 janvier 2012 18:13:00 Kaarlo Räihä, vous avez écrit :
> >>> I noticed modules/access/file.c has two parts which have msg_Err
> >> 
> >> (p_access,
> >> 
> >>> "failed to read (%m)"); (lines 187 and 297). In yearly years this
> >>> wasn't issue since it also printed the function name (access_file
> >>> error:
> >> 
> >>> fstat(3):) but now it is just filesystem error:
> >> fstat is not a verb. I think this patch makes the error harder rather
> >> than easier to understand.
> > 
> > I was under impression that read in this case refers to the function name
> > that is called earlier (line 286) not the verb. But I can resend as fstat
> > -> open if you prefer it.
> 
> open looks better, or perhaps "fstat() failed: %m" ?
> 
> It's debug messages so no need to be shakespearian english :)

I have to disagree. The error dialog is useless and it actually tells people 
to read the log to find the real problem. Error messages should be correct 
English.

This change was on purpose and I have no intention to revert it.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis