[vlc-devel] [PATCH 1/3] macosx: reenable audio items on osd

[David Fuhrmann]

Am 30.01.2012 um 21:09 schrieb Jean-Baptiste Kempf:

> On Mon, Jan 30, 2012 at 09:00:33PM +0100, David Fuhrmann wrote :
>> 
>> Am 30.01.2012 um 20:42 schrieb Jean-Baptiste Kempf:
>> 
>>> On Mon, Jan 30, 2012 at 08:39:31PM +0100, David Fuhrmann wrote :
>>>> My intention was to ask if this could possibly ok for you, before I implement something.
>>>> (See your first mail in this thread.)
>>> 
>>> I am sorry, I don't know what you mean by 'this'.
>> 
>> My idea was to intercept the (main menu) key events before they trigger the appropriate menu action (which would call the respective functions in coreinteraction.m). Then we can use  "var_SetInteger( VLCIntf->p_libvlc, "key-action", ACTIONID_VOL_* );" only for these key events and not for all other events (especially clicks on the menu or controls).
> 
> No, using key-action is wrong.

What is right then, in your opinion?

Should I use aout_Volume*** and additionally copy the appropriate osd calls from hotkeys.c into the gui code?
Another way could be to modify the core functions, as suggested earlier, e.g.:
int aout_VolumeUp (vlc_object_t *obj, int value, audio_volume_t *volp, bool show_osd_stuff)
or:
int aout_VolumeUpAndShowOSD (vlc_object_t *obj, int value, audio_volume_t *volp)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120130/637e1fa7/attachment.html>